SD-SimpleDesk

@@ -253,7 +253,7 @@ shd_attach_select.prototype.checkActive = function()

 {

 	var elements = document.getElementsByTagName('input');

 	var session_attach = 0;

-	for (i in elements)

+	for (var i in elements)

 	{

 		if (elements[i] && elements[i].type == 'checkbox' && elements[i].name == 'attach_del[]' && elements[i].checked == true)

 			session_attach++;

@@ -1857,7 +1857,7 @@ function shd_handle_attachments()

 	// ...or attach a new file...

 	if (!empty($_FILES) || !empty($_SESSION['temp_attachments']))

 	{

-		if (!empty($FILES))

+		if (!empty($_FILES))

 			$_FILES = array_reverse($_FILES);

 		shd_is_allowed_to('shd_post_attachment');

@@ -446,7 +446,6 @@ function shd_profile_show_tickets($memID)

 	list ($item_count) = $smcFunc['db_fetch_row']($request);

 	$smcFunc['db_free_result']($request);

-	$reverse = false;

 	$max_index = (int) $modSettings['defaultMaxMessages'];

 	// A little page index to help us along the way!

@@ -39,7 +39,7 @@ function shd_unread_posts()

 	global $smcFunc, $context, $user_info, $sourcedir, $txt, $scripturl, $user_profile, $modSettings;

 	// Are we using Dragooon's very swish mobile theme, or other wireless? If so, disable this.

-	if (WIRELESS || (isset($_REQUEST['thememode']) && $_REQUEST['thememode'] == 'mobile') || (isset($_COOKIE['smf4m_cookie']) && $_COOKIE['smf4m_cookie'] == 'mobile'))

+	if ((isset($_REQUEST['thememode']) && $_REQUEST['thememode'] == 'mobile') || (isset($_COOKIE['smf4m_cookie']) && $_COOKIE['smf4m_cookie'] == 'mobile'))

 		$modSettings['shd_disable_unread'] = true;

 	// We're only displaying this to staff. We didn't do this check on bootstrapping, no sense doing it every page load.

@@ -1096,7 +1096,6 @@ function shd_helpdesk_listing()

 	{

 		foreach ($context['ticket_blocks'] as $block_id => $block)

 		{

-			$num_per_page = !empty($context['shd_preferences']['blocks_' . $block_key . '_count']) ? $context['shd_preferences']['blocks_' . $block_key . '_count'] : $context['items_per_page'];

 			$url_fragment = $base_url;

 			foreach ($block_list as $block_item)

@@ -1067,8 +1067,6 @@ function shd_determine_status($action, $starter_id = 0, $replier_id = 0, $replie

 */

 function shd_no_expand_pageindex($base_url, &$start, $max_value, $num_per_page, $flexible_start = false)

 {

-	

-//	return constructPageIndex($base_url, $start, $max_value, $num_per_page, $flexible_start);

 	return preg_replace('~<span class="expand_pages"([^<]+)~i', '<span style="font-weight: bold;"> ... ', constructPageIndex($base_url, $start, $max_value, $num_per_page, $flexible_start));

 }

@@ -73,8 +73,6 @@ function shd_load_action_log_entries($start = 0, $items_per_page = 10, $sort = '

 	shd_load_language('sd_language/SimpleDeskLogAction');

 	shd_load_language('sd_language/SimpleDeskNotifications');

-	$loaded_users = array();

-

 	// We may have to exclude some items from this depending on who the user is or is not. Forum/HD admins can always see everything.

 	$exclude = shd_action_log_exclusions();

@@ -714,13 +712,13 @@ function shd_admin_log_configvar($save_vars)

  *	@since 2.1

  *	@param string $section The area this was from.

  *	@param array $extra An array of extra elements, in the following format.

- *		@param (required) string $action The action performed.

- *		@param (optional) string $setting During a setting update, this is the variable we changed.

- *		@param (optional) string $type The subaction peformed or during a setting update, int/string/etc.

- *		@param (optional) int $id The ID of the item we performed the action on.

- *		@param (optional) string $direction During a reorder up/down operation which way we moved.

- *		@param (optional) int $to The ID of the destination item used during copy/move operation.

- *		@param (optional) int $from The ID of the source item used during the copy/move operation

+ *		(required) string $action The action performed.

+ *		(optional) string $setting During a setting update, this is the variable we changed.

+ *		(optional) string $type The subaction peformed or during a setting update, int/string/etc.

+ *		(optional) int $id The ID of the item we performed the action on.

+ *		(optional) string $direction During a reorder up/down operation which way we moved.

+ *		(optional) int $to The ID of the destination item used during copy/move operation.

+ *		(optional) int $from The ID of the source item used during the copy/move operation

 */

 function shd_admin_log($action, $extra)

 {

@@ -779,8 +777,6 @@ function shd_load_admin_log_entries($start = 0, $items_per_page = 10, $sort = 'l

 	shd_load_language('sd_language/SimpleDeskLogAction');

 	shd_load_language('sd_language/SimpleDeskNotifications');

-	$loaded_users = array();

-

 	$request = shd_db_query('','

 		SELECT la.id_action, la.log_time, la.ip, la.action, la.extra,

 		IFNULL(mem.id_member, 0) AS id_member, IFNULL(mem.real_name, {string:blank}) AS real_name, IFNULL(mg.group_name, {string:na}) AS group_name

@@ -135,7 +135,6 @@ function shd_create_ticket_post(&$msgOptions, &$ticketOptions, &$posterOptions)

 		$msgOptions['modified']['id'] = empty($msgOptions['modified']['id']) ? 0 : (int) $msgOptions['modified']['id'];

 		$msgOptions['modified']['name'] = empty($msgOptions['modified']['name']) ? '' : $msgOptions['modified']['name'];

-		$cancel = false;

 		if (empty($msgOptions['modified']['time']) || (empty($msgOptions['modified']['name']) && empty($msgOptions['modified']['id'])))

 			$modified = false;

@@ -130,15 +130,6 @@ function template_shd_admin()

 					echo '

 								<strong>', $group['title'], '</strong>', !empty($group['desc']) ? ' - <em class="smalltext">' . $group['desc'] . '</em>' : '', '<hr>';

-					/*// Try to make this read nicely.

-					if (count($group['members']) <= 2)

-						echo implode(' ' . $txt['shd_credits_and'] . ' ', $group['members']);

-					else

-					{

-						$last_peep = array_pop($group['members']);

-						echo implode(', ', $group['members']), ', ', $txt['shd_credits_and'], ' ', $last_peep;

-					}*/

-

 					$cur_member = 1;

 					foreach ($group['members'] AS $member)

 					{

@@ -709,7 +700,7 @@ function template_shd_admin_log()

 	if (empty($context['actions']))

 		echo '

 			<tr class="windowbg">

-				<td ', $action['can_remove'] && $context['can_delete'] ? 'colspan="6"' : 'colspan="5"',' class="shd_noticket">', $txt['shd_admin_actionlog_none'], '</td>

+				<td ', $context['can_delete'] ? 'colspan="6"' : 'colspan="5"',' class="shd_noticket">', $txt['shd_admin_actionlog_none'], '</td>

 			</tr>';

 	else

 	{

@@ -729,7 +720,7 @@ function template_shd_admin_log()

 	echo '

 			<tr class="windowbg">

-				<td ', $action['can_remove'] && $context['can_delete'] ? 'colspan="6"' : 'colspan="5"','>

+				<td ', $context['can_delete'] ? 'colspan="6"' : 'colspan="5"','>

 					<span class="floatright smalltext">', $context['page_index'], '</span>

 					<span class="smalltext shd_empty_log"><img src="', $settings['default_images_url'], '/simpledesk/delete.png" alt="X" /> <a href="', $scripturl, '?action=admin;area=helpdesk_info;sa=adminlog', $context['url_sort'], $context['url_order'], ';removeall" onclick="return confirm(', JavaScriptEscape(sprintf($txt['shd_admin_actionlog_removeall_confirm'], $context['daysdisable'])), ');">', $txt['shd_admin_actionlog_removeall'], '</a></span>

 				</td>

@@ -238,7 +238,6 @@ function template_shd_custom_field_edit()

 	foreach ($context['field_icons'] as $icon)

 	{

 		list($file, $desc) = $icon;

-		$path = $settings['default_theme_dir'] . '/images/simpledesk/' . $file;

 		echo '

 									<option value="', $file, '"', $context['field_icon_value'] == $file ? ' selected="selected"' : '','>', $desc, '</option>';

 	}

@@ -293,7 +292,7 @@ function template_shd_custom_field_edit()

 	foreach ($context['field_types'] as $field => $details)

 	{

-		list($field_desc, $class) = $details;

+		list($field_desc,) = $details;

 		echo '

 									<option value="', $field, '"', ($context['field_type_value'] == $field ? ' selected="selected"' : ''), '>', $field_desc, '</option>';

 	}

@@ -695,10 +695,6 @@ function template_inline_attachments($msg)

 	{

 		echo '

 							<table width="90%">';

-		/*echo '

-							<div class="smalltext">

-								<strong>', $txt['shd_ticket_attachments'], '</strong><br>

-								<ul class="shd_replyattachments">';*/

 		$count = 0;

 		$firstrow = true;

@@ -745,9 +741,6 @@ function template_inline_attachments($msg)

 			$firstrow = false;

 		}

-		/*echo '

-								</ul>

-							</div>';*/

 		echo '

 							</table>';

 	}

@@ -519,7 +519,6 @@ function template_shd_menu_header($header, $string)

 		if (isset($_REQUEST['st_' . $block_key]))

 			$link .= ';st_' . $block_key . '=' . $block['start'];

-	$direction = 'down';

 	// Now for sorting direction per block

 	foreach ($context['ticket_blocks'] as $block_key => $block)

 	{

@@ -568,7 +567,7 @@ function template_shd_maintenance_below()

 // Provide a placeholder in the event template_button_strip isn't defined (like in the mobile templates)

 if (!function_exists('template_button_strip'))

 {

-	function template_button_strip($navigation, $direction)

+	function template_button_strip($navigation, $direction = '', $strip_options = array())

 	{

 	}

 }