SD-SimpleDesk

@@ -271,9 +271,9 @@ function QuickReply(oOptions)

 QuickReply.prototype.quote = function (e)

 {

 	e.preventDefault();

-	iMessageId = e.currentTarget.dataset.id;

+	this.iMessageId = e.currentTarget.dataset.id;

-	shd_getJSONDocument(smf_prepareScriptUrl(this.opt.sScriptUrl) + 'action=helpdesk;sa=ajax;op=quote;quote=' + iMessageId + ';' + this.opt.sSession + ';json' + ';mode=' + (oEditorHandle_shd_message.bRichTextEnabled ? 1 : 0), this.onQuoteReceived.bind(this));

+	shd_getJSONDocument(smf_prepareScriptUrl(this.opt.sScriptUrl) + 'action=helpdesk;sa=ajax;op=quote;quote=' + this.iMessageId + ';' + this.opt.sSession + ';json' + ';mode=' + (oEditorHandle_shd_message.bRichTextEnabled ? 1 : 0), this.onQuoteReceived.bind(this));

 	// Move the view to the quick reply box.

 	window.location.hash = navigator.appName == 'Microsoft Internet Explorer' ? this.opt.sJumpAnchor : '#' + this.opt.sJumpAnchor;

@@ -295,7 +295,7 @@ function CannedReply(oOptions)

 	$('#' + this.opt.sCannedRepliesContainerId + ' input.button').on('click', this.getReply.bind(this));

 }

-CannedReply.prototype.getReply = function (e)

+CannedReply.prototype.getReply = function ()

 {

 	var iReplyId = $('#' + this.opt.sSelectContainerId).val();

 	if (!iReplyId || parseInt(iReplyId, 10) < 1)

@@ -519,7 +519,7 @@ function goAdvanced(oOptions)

 	$(document).ready(this.init.bind(this));

 }

-goAdvanced.prototype.init = function(e)

+goAdvanced.prototype.init = function()

 {

 	$('#' + this.opt.sBbcContainerId +

 		', .' + this.opt.sBbcContainerEditorClass +

@@ -554,7 +554,7 @@ shd_dept_filter.prototype.startFilter = function ()

 	$(this.opt.oFields).each(this.filterDept.bind(this));

 }

-shd_dept_filter.prototype.filterDept = function (index, value)

+shd_dept_filter.prototype.filterDept = function (index)

 {

 	this.currentDept = $('#' + this.opt.sSelectContainerId).val();

@@ -9,7 +9,7 @@ $(document).ready(function(){

 	$('input[type="submit"].save').parent('form').on('submit', function(){

 		submitonce(this.currentTarget);

 	});

-	$('input[type="submit"].save').on('click', function(e){

+	$('input[type="submit"].save').on('click', function(){

 		submitThisOnce(this.currentTarget);

 	});

 });

@@ -107,7 +107,7 @@ sd_AdminIndex.prototype.checkUpdateAvailable = function ()

 // Ticket number information...

 sd_AdminIndex.prototype.TickekTotals = function ()

 {

-	var infocontainer = $('#' + this.opt.sTotalTicketsInfoContainerID).toggle();

+	$('#' + this.opt.sTotalTicketsInfoContainerID).toggle();

 }

 // Modified, SMF 2.0 ToggleItem

@@ -129,17 +129,17 @@ shd_plugins.prototype.setupPlugins = function (index, itemID)

 shd_plugins.prototype.togglePlugin = function (e)

 {

 	e.preventDefault();

-	itemID = e.currentTarget.dataset.plugin;

+	this.itemID = e.currentTarget.dataset.plugin;

 	// Toggle the hidden item.

 	this.oItemValueHandle = $('#' + this.opt.sFeatureClass.replace('%itemid%', itemID));

-	this.bItemValue = this.oItemValueHandle.val() == 0 ? 1 : 0;

+	this.bItemValue = this.oItemValueHandle.val() == '0' ? 1 : 0;

 	// Change the image, alternative text and the title.

-	$('#' + this.opt.sSwitchClass.replace('%itemid%', itemID)).attr('src', this.bItemValue === 1 ? this.opt.sPluginOnImg : this.opt.sPluginOffImg);

-	$('#' + this.opt.sSwitchClass.replace('%itemid%', itemID)).attr('alt', this.bItemValue === 1 ? this.opt.sPluginOnText : this.opt.sPluginOffText);

-	$('#' + this.opt.sSwitchClass.replace('%itemid%', itemID)).attr('title', this.bItemValue === 1 ? this.opt.sPluginOnText : this.opt.sPluginOffText);

-	$('#' + this.opt.sFeatureClass.replace('%itemid%', itemID)).val(this.bItemValue);

+	$('#' + this.opt.sSwitchClass.replace('%itemid%', this.itemID)).attr('src', this.bItemValue === 1 ? this.opt.sPluginOnImg : this.opt.sPluginOffImg);

+	$('#' + this.opt.sSwitchClass.replace('%itemid%', this.itemID)).attr('alt', this.bItemValue === 1 ? this.opt.sPluginOnText : this.opt.sPluginOffText);

+	$('#' + this.opt.sSwitchClass.replace('%itemid%', this.itemID)).attr('title', this.bItemValue === 1 ? this.opt.sPluginOnText : this.opt.sPluginOffText);

+	$('#' + this.opt.sFeatureClass.replace('%itemid%', this.itemID)).val(this.bItemValue);

 	// Don't reload.

 	return false;

@@ -309,38 +309,38 @@ shd_AttributeValidate.prototype.focusValidator = function (e)

 /* Reattribute Posts: Validate if we can start the process to reattribute */

 shd_AttributeValidate.prototype.validator = function ()

 {

-	origText = this.opt.sOrigText;

-	origTextStarter = this.opt.sOrigTextStarter;

-	valid = true;

+	this.origText = this.opt.sOrigText;

+	this.origTextStarter = this.opt.sOrigTextStarter;

+	this.valid = true;

 	// Do all the fields!

 	if (!$('#' + this.opt.sToContainerId).val())

-		valid = false;

+		this.valid = false;

-	warningMessage = origText.replace(/%member_to%/, $('#' + this.opt.sToContainerId).value);

+	warningMessage = this.origText.replace(/%member_to%/, $('#' + this.opt.sToContainerId).value);

 	if ($('#' + this.opt.sTypeEmailContainerId).is(":checked"))

 	{

 		$('#' + this.opt.sStarterContainerId + ', #' + this.opt.sFromContainerId).val("");

-			valid = $('#' + this.opt.sEmailContainerId).val() != '';

+			this.valid = $('#' + this.opt.sEmailContainerId).val() != '';

 		warningMessage = warningMessage.replace(/%type%/, this.opt.sEmailConfirmText).replace(/%find%/, $('#' + this.opt.sEmailContainerId).val());

 	}

 	else if ($('#' + this.opt.sTypeStarterContainerId).is(":checked"))

 	{

 		$('#' + this.opt.sEmailContainerId + ' #' + this.opt.sFromContainerId).val("");

-			valid = $('#' + this.opt.sStarterContainerId).val() != '';

-		warningMessage = origTextStarter.replace(/%member_to%/, $('#' + this.opt.sToContainerId).val()).replace(/%find%/, $('#' + this.opt.sStarterContainerId).val());			

+			this.valid = $('#' + this.opt.sStarterContainerId).val() != '';

+		warningMessage = this.origTextStarter.replace(/%member_to%/, $('#' + this.opt.sToContainerId).val()).replace(/%find%/, $('#' + this.opt.sStarterContainerId).val());			

 	}

 	else

 	{

 		$('#' + this.opt.sEmailContainerId + ' #' + this.opt.sStarterContainerId).val("");

-		valid = $('#' + this.opt.sFromContainerId).val() != '';

+		this.valid = $('#' + this.opt.sFromContainerId).val() != '';

 		warningMessage = warningMessage.replace(/%type%/, this.opt.sFromConfirmText).replace(/%find%/, $('#' + this.opt.sFromContainerId).val());

 	}

-	$('#' + this.opt.sDoAttributeContainerId).prop("disabled", valid ? false : true);

+	$('#' + this.opt.sDoAttributeContainerId).prop("disabled", this.valid ? false : true);

 }

 /* Roles Management */

@@ -199,10 +199,10 @@ function template_shd_admin_maint_findrepairdone()

 		// Heh, super squeeky buns time!

 		// Each test has potentially its own feedback to give. So we'll handle each one separately.

-		foreach (array('zero_tickets', 'zero_msgs', 'deleted', 'first_last', 'status', 'starter_updater', 'invalid_dept') as $maintResult)

-			if (!empty($context['maintenance_result'][$maintResult]))

+		foreach (array('zero_tickets', 'zero_msgs', 'deleted', 'first_last', 'status', 'starter_updater', 'invalid_dept') as $maint)

+			if (!empty($context['maintenance_result'][$maint]))

 				echo '

-				<p class="padding">', sprintf($txt['shd_maint_' . $maintTxt], $context['maintenance_result'][$maintResult]), '</p>';

+				<p class="padding">', sprintf($txt['shd_maint_' . $maint], $context['maintenance_result'][$maint]), '</p>';

 		echo '

 				<p class="padding">

@@ -46,9 +46,11 @@ function template_viewticket()

 					<a href="', $button['url'], '"', (!empty($button['is_last']) ? ' id="last"' : ''), '', (!empty($button['onclick']) ? ' onclick="' . $button['onclick'] . '"' : ''), '><img src="', $settings['default_images_url'], '/simpledesk/', $button['icon'], '.png" alt="', $button['alt'], '" title="', $txt[$button['text']], '"> ', $txt[$button['text']], '</a>';

 	elseif ($modSettings['shd_ticketnav_style'] == 'sdcompact')

 		foreach ($context['ticket_navigation'] as $button)

+		{

 			if (!empty($button['display']))

 				echo '

 					<a href="', $button['url'], '"', (!empty($button['is_last']) ? ' id="last"' : ''), '', (!empty($button['onclick']) ? ' onclick="' . $button['onclick'] . '"' : ''), '><img src="', $settings['default_images_url'], '/simpledesk/', $button['icon'], '.png" alt="', $button['alt'], '" title="', $txt[$button['text']], '"></a>';

+		}

 	echo '

 				</span>

@@ -778,7 +778,7 @@ function template_ticket_do_replies()

 function template_ticket_do_single_reply($reply)

 {

-	global $context, $modSettings, $settings, $txt;

+	global $context, $modSettings, $settings, $options, $scripturl, $txt;

 	echo '

 					<div class="windowbg" id="reply', $reply['id'], '">