SD-SimpleDesk

@@ -714,7 +714,7 @@ function shd_admin_cf_icons()

 	$dir = dir($settings['default_theme_dir'] . '/images/simpledesk/cf/');

 	$files = array();

-	if (!is_resource($dir))

+	if (!is_object($dir) || is_null($dir))

 		return $iconlist;

 	while ($line = $dir->read())

@@ -351,7 +351,7 @@ function shd_admin_save_dept()

 		if ($smcFunc['db_num_rows']($query) == 0)

 		{

 			$smcFunc['db_free_result']($query);

-			shd_fatal_lang_error(shd_unknown_dept, false);

+			shd_fatal_lang_error('shd_unknown_dept', false);

 		}

 		list($dept_order) = $smcFunc['db_fetch_row']($query);

 		$smcFunc['db_free_result']($query);

@@ -101,12 +101,13 @@ function shd_admin_maint_home()

 {

 	global $context, $txt, $smcFunc;

-	$depts = shd_allowed_to('access_helpdesk', false);

-	if (count($depts) > 1)

-	{

 	$context['dept_list'] = array(

 		0 => $txt['shd_admin_maint_massdeptmove_select'],

 	);

+

+	$depts = shd_allowed_to('access_helpdesk', false);

+	if (!is_bool($depts) && count($depts) > 1)

+	{

 		$query = $smcFunc['db_query']('', '

 			SELECT id_dept, dept_name

 			FROM {db_prefix}helpdesk_depts

@@ -671,7 +671,12 @@ function shd_ajax_notify()

 			'ticket' => $context['ticket_id'],

 		)

 	);

-	if ($smcFunc['db_num_rows']($query) != 0)

+	if (empty($smcFunc['db_num_rows']($query)))

+	{

+		$smcFunc['db_free_result']($query);

+		return array('success' => false, 'error' => $txt['shd_no_ticket']);

+	}

+

 	$ticket = $smcFunc['db_fetch_assoc']($query);

 	$smcFunc['db_free_result']($query);

@@ -381,6 +381,7 @@ function shd_view_ticket()

 			continue;

 		// If this is going to be displayed for the individual ticket, we need to figure out where it should go.

+		$pos = CFIELD_PLACE_DETAILS;

 		if ($row['field_loc'] & CFIELD_TICKET)

 			$pos = $placements[$row['placement']];

@@ -833,7 +834,7 @@ function shd_prepare_ticket_context()

 		$memberContext[$message['id_member']]['group'] = $txt['guest_title'];

 		$memberContext[$message['id_member']]['link'] = $message['poster_name'];

 		$memberContext[$message['id_member']]['email'] = $message['poster_email'];

-		$memberContext[$message['id_member']]['show_email'] = showEmailAddress(true, 0);

+		$memberContext[$message['id_member']]['show_email'] = false;

 		$memberContext[$message['id_member']]['is_guest'] = true;

 		$memberContext[$message['id_member']]['group_icons'] = '';

 	}

@@ -365,6 +365,11 @@ function shd_save_ticket()

 			'link' => '<span class="error">' . $txt['shd_unassigned'] . '</span>',

 		);

 		$num_replies = 0;

+

+		$context['ticket_form'] = array(

+			'first_msg' => 0,

+			'last_msg' => 0,

+		);

 	}

 	else

 	{

@@ -389,16 +394,19 @@ function shd_save_ticket()

 			'link' => !empty($ticketinfo['assigned_id']) ? shd_profile_link($ticketinfo['assigned_name'], $ticketinfo['assigned_id']) : '<span class="error">' . $txt['shd_unassigned'] . '</span>',

 		);

 		$num_replies = $ticketinfo['num_replies'];

-	}

 		$context['ticket_form'] = array(

+			'first_msg' => $ticketinfo['id_first_msg'],

+			'last_msg' => $ticketinfo['id_last_msg'],

+		);

+	}

+

+	$context['ticket_form'] += array(

 		'is_new' => $new_ticket,

 		'is_reply' => false,

 		'dept' => isset($newdept) ? $newdept : $dept,

 		'form_title' => !$new_ticket ? $txt['shd_edit_ticket'] : $txt['shd_create_ticket'],

 		'form_action' => $scripturl . '?action=helpdesk;sa=saveticket',

-		'first_msg' => !$new_ticket ? $ticketinfo['id_first_msg'] : 0,

-		'last_msg' => !$new_ticket ? $ticketinfo['id_last_msg'] : 0,

 		'message' => $_POST['shd_message'],

 		'subject' => $_POST['subject'],

 		'ticket' => $context['ticket_id'],

@@ -940,7 +948,6 @@ function shd_post_reply()

 			{

 				require_once($sourcedir . '/Subs-Editor.php');

 				$row['body'] = strtr($row['body'], array('<' => '#smlt#', '>' => '#smgt#', '&' => '#smamp#'));

-				$row['body'] = bbc_to_html($row['body']);

 				$lb = '<br>';

 			}

 			else

@@ -1787,7 +1794,7 @@ function shd_check_attachments()

 					if (!in_array(strtolower(substr(strrchr($uplfile['name'], '.'), 1)), explode(',', strtolower($modSettings['attachmentExtensions']))))

 					{

 						checkSubmitOnce('free');

-						fatal_error($uplfile['name'] . '.<br>' . $txt['cant_upload_type'] . ' ' . $modSettings['attachmentExtensions'] . '.', false);

+						shd_fatal_error($uplfile['name'] . '.<br>' . $txt['cant_upload_type'] . ' ' . $modSettings['attachmentExtensions'] . '.', false);

 					}

 				}

@@ -1801,7 +1808,7 @@ function shd_check_attachments()

 					$dir = opendir($current_attach_dir);

 					if (!is_resource($dir))

-						fatal_lang_error('cant_access_upload_path', 'critical');

+						shd_fatal_lang_error('cant_access_upload_path', 'critical');

 					while ($file = readdir($dir))

 					{

@@ -28,6 +28,12 @@

 if (!defined('SMF'))

 	die('If only you could draw like a drunken monkey...');

+/**

+ *	Sets up the main profile data

+ *

+ *	@since 1.0

+ *	@param int $memID The member ID

+*/

 function shd_profile_main($memID)

 {

 	global $context, $txt, $scripturl, $sourcedir, $user_info, $settings, $user_profile, $modSettings;

@@ -125,6 +131,12 @@ function shd_profile_main($memID)

 	$context['template_layers'][] = 'shd_profile_navigation';

 }

+/**

+ *	The frontpage profile

+ *

+ *	@since 1.0

+ *	@param int $memID The member ID

+*/

 function shd_profile_frontpage($memID)

 {

 	global $context, $memberContext, $txt, $modSettings, $user_info, $user_profile, $sourcedir, $scripturl, $smcFunc;

@@ -263,6 +275,12 @@ function shd_profile_frontpage($memID)

 	}

 }

+/**

+ *	Prefernces for a helpdesk member

+ *

+ *	@since 1.0

+ *	@param int $memID The member ID

+*/

 function shd_profile_preferences($memID)

 {

 	global $context, $txt, $scripturl, $sourcedir, $user_info, $smcFunc;

@@ -355,6 +373,12 @@ function shd_profile_preferences($memID)

 	}

 }

+/**

+ *	Show all the ticket information.

+ *

+ *	@since 1.0

+ *	@param int $memID The member ID

+*/

 function shd_profile_show_tickets($memID)

 {

 	global $txt, $user_info, $scripturl, $modSettings, $smcFunc, $board, $user_profile, $context;

@@ -501,6 +525,12 @@ function shd_profile_show_tickets($memID)

 		$context['items'] = array_reverse($context['items'], true);

 }

+/**

+ *	Show the notifications for a helpdesk member

+ *

+ *	@since 1.0

+ *	@param int $memID The member ID

+*/

 function shd_profile_show_notify_override($memID)

 {

 	global $txt, $user_info, $scripturl, $modSettings, $smcFunc, $board, $user_profile, $context;

@@ -541,8 +571,16 @@ function shd_profile_show_notify_override($memID)

 		);

 		$context['tickets'][] = $row;

 	}

+

+	return true;

 }

+/**

+ *	Profile Permissions for a member

+ *

+ *	@since 1.0

+ *	@param int $memID The member ID

+*/

 function shd_profile_permissions($memID)

 {

 	global $context, $txt, $scripturl, $sourcedir, $user_info, $smcFunc, $user_profile, $settings;

@@ -682,6 +720,12 @@ function shd_profile_permissions($memID)

 				$context['member_permissions']['denied'][$permission][] = $role_id;

 }

+/**

+ *	This members action log information.

+ *

+ *	@since 1.0

+ *	@param int $memID The member ID

+*/

 function shd_profile_actionlog($memID)

 {

 	global $context, $txt, $scripturl, $sourcedir, $user_info, $settings;

@@ -699,6 +743,12 @@ function shd_profile_actionlog($memID)

 }

+/**

+ *	Shows the theme options for SimpleDesk.

+ *

+ *	@since 1.0

+ *	@param int $memID The member ID

+*/

 function shd_profile_theme_wrapper($memID)

 {

 	global $txt, $context, $user_profile, $modSettings, $settings, $user_info, $smcFunc, $sourcedir, $profile_fields;

@@ -404,6 +404,9 @@ function shd_load_user_perms()

 		$tickets_private_any_dept = shd_allowed_to('shd_view_ticket_private_any', false);

 		$tickets_private_own_dept = shd_allowed_to('shd_view_ticket_private_own', false);

+		if (is_bool($tickets_private_any_dept) || is_bool($tickets_private_own_dept))

+			return shd_fatal_error('Tickets have no bools');

+

 		$clauses = array();

 		$privacy_clauses = array();