! Collapsible permissions blocks in admin permissions screen are now expanded by default and only made collapsible if JS is enabled. [Bug 702]
gruffen

gruffen commited on 2011-05-26 09:10:28
Showing 1 changed files, with 26 additions and 4 deletions.

... ...
@@ -308,6 +308,7 @@ function template_shd_edit_role()
308 308
 						document.getElementById("permfooter_" + block).style.display = "none";
309 309
 						document.getElementById("permexpandicon_" + block).src = ', JavaScriptEscape($settings['images_url'] . '/expand.gif'), ';
310 310
 					}
311
+					document.getElementById("permexpandicon_" + block).style.display = "";
311 312
 				}
312 313
 
313 314
 				// ]', ']></script>
... ...
@@ -342,6 +343,8 @@ function template_shd_edit_role()
342 343
 			$permission_set[$details[1]][] = $permission;
343 344
 	}
344 345
 
346
+	$displayed_sets = array();
347
+
345 348
 	foreach ($context['shd_permissions']['group_display'] as $cell => $rows)
346 349
 	{
347 350
 		echo '
... ...
@@ -352,19 +355,21 @@ function template_shd_edit_role()
352 355
 			if (empty($permission_set[$rowitem]))
353 356
 				continue;
354 357
 
358
+			$displayed_sets[] = $rowitem;
359
+
355 360
 			echo '
356
-						<div class="cat_bar" id="permheader_', $rowitem, '">
361
+						<div class="cat_bar grid_header" id="permheader_', $rowitem, '">
357 362
 							<h3 class="catbg">
358 363
 								<span class="floatright">
359 364
 									<a class="permcollapse" href="#" onclick="shd_toggleblock(\'', $rowitem, '\'); return false;">
360
-										<img src="', $settings['images_url'], '/expand.gif" id="permexpandicon_', $rowitem, '" />
365
+										<img src="', $settings['images_url'], '/expand.gif" id="permexpandicon_', $rowitem, '" style="display:none;" />
361 366
 									</a>
362 367
 								</span>
363 368
 								<img src="', $settings['default_images_url'], '/simpledesk/', $rowicon, '" alt="*" />
364 369
 								<a href="#" onclick="shd_toggleblock(\'', $rowitem, '\'); return false;">', $txt['shd_permgroup_' . $rowitem], '</a>
365 370
 							</h3>
366 371
 						</div>
367
-						<div class="roundframe" id="permcontent_', $rowitem, '" style="display:none;">
372
+						<div class="roundframe" id="permcontent_', $rowitem, '">
368 373
 							<div class="content">
369 374
 								<dl class="permsettings">';
370 375
 
... ...
@@ -418,7 +423,7 @@ function template_shd_edit_role()
418 423
 								</dl>
419 424
 							</div>
420 425
 						</div>
421
-						<span class="lowerframe" id="permfooter_', $rowitem, '" style="display:none;"><span></span></span>
426
+						<span class="lowerframe" id="permfooter_', $rowitem, '"><span></span></span>
422 427
 						<br />';
423 428
 		}
424 429
 
... ...
@@ -426,6 +431,23 @@ function template_shd_edit_role()
426 431
 					</div>';
427 432
 	}
428 433
 
434
+	if (!empty($displayed_sets))
435
+	{
436
+		echo '
437
+						<script type="text/javascript"><!-- // --><![CDATA[';
438
+
439
+		if (!empty($displayed_sets))
440
+			echo '
441
+						var hidden_blocks = ["', implode('","', $displayed_sets), '"];
442
+						for (i in hidden_blocks)
443
+						{
444
+							shd_toggleblock(hidden_blocks[i]);
445
+						}';
446
+
447
+		echo '
448
+						// ]', ']></script>';
449
+	}
450
+
429 451
 	echo '
430 452
 					<div class="tborder floatleft" style="width: 100%;">
431 453
 						<div class="cat_bar grid_header">
432 454