Found some bugs
jdarwood007

jdarwood007 commited on 2020-09-27 08:04:04
Showing 5 changed files, with 24 additions and 9 deletions.

... ...
@@ -134,13 +134,13 @@ class SFSA
134 134
 		}
135 135
 		else
136 136
 		{
137
-			$this->adminPageURL = $scripturl . '?action=admin;area=securitysettings;sa=sfs';
137
+			$this->adminPageURL = $scripturl . '?action=admin;area=modsettings;sa=sfs';
138 138
 			$this->adminLogURL = $scripturl . '?action=admin;area=logs;sa=sfslog';
139 139
 
140
-			$admin_areas['config']['areas']['securitysettings']['subsections']['sfs'] = array(
140
+			$admin_areas['config']['areas']['modsettings']['subsections']['sfs'] = array(
141 141
 				$this->SFSclass->txt('sfs_admin_area')
142 142
 			);
143
-			$admin_areas['config']['areas']['securitysettings']['subsections']['sfslog'] = array(
143
+			$admin_areas['maintenance']['areas']['logs']['subsections']['sfslog'] = array(
144 144
 				$this->SFSclass->txt('sfs_admin_logs')
145 145
 			);
146 146
 		}
... ...
@@ -234,7 +234,7 @@ class SFSA
234 234
 				array('check', 'sfs_emailcheck'),
235 235
 			'',
236 236
 				array('check', 'sfs_usernamecheck'),
237
-				array('float', 'sfs_username_confidence'),
237
+				array('float', 'sfs_username_confidence', 'step' => '0.01'),
238 238
 			'',
239 239
 				array('check', 'sfs_ipcheck'),
240 240
 				array('check', 'sfs_ipcheck_autoban'),
... ...
@@ -316,7 +316,7 @@ class SFSA
316 316
 	public static function hook_manage_logs(array &$log_functions): bool
317 317
 	{
318 318
 		// Add our logs sub action.
319
-		$log_functions['sfslog'] = array('StopForumSpam.php', 'startupLogs');
319
+		$log_functions['sfslog'] = array('SFS-Subs-Logs.php', 'SFSL::startupLogs');
320 320
 
321 321
 		return self::selfClass()->AddToLogMenu($log_functions);
322 322
 	}
... ...
@@ -956,6 +956,21 @@ class SFSA
956 956
 		return (int) $entry_count;
957 957
 	}
958 958
 
959
+	/**
960
+	 * Get params
961
+	 *
962
+	 * @internal
963
+	 * @CalledIn SMF 2.0, SMF 2.1
964
+	 * @version 1.1
965
+	 * @since 1.0
966
+	 * @return string The column we are searching.
967
+	 */
968
+	public function get(string $var)
969
+	{
970
+		if (isset($this->{$var}))
971
+			return $this->{$var};
972
+	}
973
+
959 974
 	/**
960 975
 	 * Remove all logs, except those less than 24 hours old.
961 976
 	 *
... ...
@@ -76,7 +76,7 @@ class SFSL
76 76
 		global $smcFunc;
77 77
 
78 78
 		$this->SFSclass = &$smcFunc['classSFS'];
79
-		$this->SFSAclass = &SFSA::selfClass();
79
+		$this->SFSAclass = SFSA::selfClass();
80 80
 	}
81 81
 
82 82
 	/**
... ...
@@ -295,7 +295,7 @@ class SFS
295 295
 			foreach ($possibleUserNames as $searchKey)
296 296
 				if (!empty($_POST[$searchKey]))
297 297
 				{
298
-					$checks[] = array('username', $_POST[$searchKey]);
298
+					$checks[] = array('username' => $_POST[$searchKey]);
299 299
 					break;
300 300
 				}
301 301
 
... ...
@@ -304,7 +304,7 @@ class SFS
304 304
 			foreach ($possibleUserNames as $searchKey)
305 305
 				if (!empty($_POST[$searchKey]))
306 306
 				{
307
-					$checks[] = array('email', $_POST[$searchKey]);
307
+					$checks[] = array('email' => $_POST[$searchKey]);
308 308
 					break;
309 309
 				}
310 310
 
... ...
@@ -27,6 +27,7 @@ $table = array(
27 27
 		db_field('id_member', 'mediumint'),
28 28
 		db_field('username', 'varchar', 255),
29 29
 		db_field('email', 'varchar', 255),
30
+		db_field('url', 'varchar', 255),
30 31
 		db_field('ip', 'varchar', 255),
31 32
 		db_field('ip2', 'varchar', 255),
32 33
 		db_field('checks', 'mediumtext'),
... ...
@@ -63,7 +63,6 @@
63 63
 	<uninstall for="2.1 RC3, 2.1.*">
64 64
 		<!-- database changes, undone -->
65 65
 		<database>install_sfs.php</database>
66
-		<code type="file">uninstall-sd-required.php</code>
67 66
 
68 67
 		<!-- All the hooks, removed -->
69 68
 			<!-- Main Section -->
70 69